Merged
Conversation
WyriHaximus
force-pushed
the
3.x-raise-minimum-php-version-to-7.1PLUS
branch
from
8dfab30 to
a6bc754
Compare
WyriHaximus
force-pushed
the
3.x-raise-minimum-php-version-to-7.1PLUS
branch
2 times, most recently
from
d62cd4e to
ec578d4
Compare
clue
force-pushed
the
3.x-raise-minimum-php-version-to-7.1PLUS
branch
from
eee05cc to
1321766
Compare
clue
approved these changes
May 15, 2024
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@WyriHaximus Went over your changes together with @cassifyit and addressed all outstanding issues, great work, now let's get this shipped! 
For the reference: Link to diff between original eee05cc and new 1321766: https://gist.github.com/clue/98910c5ec0c390225d702d897e366304)
clue
force-pushed
the
3.x-raise-minimum-php-version-to-7.1PLUS
branch
from
1321766 to
cde4017
Compare
SimonFrings
approved these changes
May 16, 2024
Member
SimonFrings
left a comment
SimonFrings
left a comment
There was a problem hiding this comment.
Pull request looks good to me, let's get this in 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset updates the project to require PHP 7.1+ and drop legacy PHP < 7.1 and HHVM as discussed in #271. I'm marking this as a BC break for anybody still stuck on very old PHP versions, but there's little chance this will affect any current projects otherwise.
This PR aims to contain the minimal changeset to update the PHP version requirement only. Follow-up PRs will update our APIs to leverage newer language features.
Builds on top of #269, #272, #273 and others
Refs reactphp/cache#58 and reactphp/stream#175